Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: sdk/lib/collection/list.dart

Issue 18282008: Revert "Move toString() to collection classes." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/collection/linked_list.dart ('k') | sdk/lib/collection/maps.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/collection/list.dart
diff --git a/sdk/lib/collection/list.dart b/sdk/lib/collection/list.dart
index 7b4a074b7eebb2e4399a3f9b736fcd0784122a01..5c81ae761efd5c7f9eceebfe1146765ae570ea22 100644
--- a/sdk/lib/collection/list.dart
+++ b/sdk/lib/collection/list.dart
@@ -28,9 +28,6 @@ typedef ListBase<E> = Object with ListMixin<E>;
* mixin to prevent all modifications.
*/
abstract class ListMixin<E> implements List<E> {
- // A list to identify cyclic lists during toString() calls.
- static List _toStringList = new List();
-
// Iterable interface.
Iterator<E> get iterator => new ListIterator<E>(this);
@@ -480,22 +477,5 @@ abstract class ListMixin<E> implements List<E> {
Iterable<E> get reversed => new ReversedListIterable(this);
- String toString() {
- for (int i = 0; i < _toStringList.length; i++) {
- if (identical(_toStringList[i], this)) { return '[...]'; }
- }
-
- var result = new StringBuffer();
- try {
- _toStringList.add(this);
- result.write('[');
- result.writeAll(this, ', ');
- result.write(']');
- } finally {
- assert(identical(_toStringList.last, this));
- _toStringList.removeLast();
- }
-
- return result.toString();
- }
+ String toString() => ToString.iterableToString(this);
}
« no previous file with comments | « sdk/lib/collection/linked_list.dart ('k') | sdk/lib/collection/maps.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698