Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182413007: Add new <curly-block> element. (Closed)

Created:
6 years, 9 months ago by turnidge
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add new <curly-block> element. This is an expandable curly-brace block. - Show pointer cursor when over link instead of text input. - Make the link easier to click with inline-block, &nbsp. - Show a busy cursor and hide the link when an expand is pending. - Use boxed +/- for expand/contract icons. (We can change these later). BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33297

Patch Set 1 #

Patch Set 2 : gen js / fix bugs with reload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1485 lines, -1262 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 7 chunks +57 lines, -34 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 293 chunks +629 lines, -571 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 7 chunks +57 lines, -34 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 293 chunks +629 lines, -571 lines 0 comments Download
M runtime/bin/vmservice/client/lib/observatory_elements.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/observatory_elements.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/curly_block.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/curly_block.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart View 1 2 chunks +15 lines, -10 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html View 1 3 chunks +11 lines, -20 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/nav_bar.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html View 4 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
Something for your morning bus ride...
6 years, 9 months ago (2014-03-04 01:50:07 UTC) #1
Cutch
lgtm
6 years, 9 months ago (2014-03-04 17:58:48 UTC) #2
turnidge
6 years, 9 months ago (2014-03-04 20:26:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r33297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698