Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

Issue 182413007: Add new <curly-block> element. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js / fix bugs with reload Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
index ec99c73c6fb73dd7c2ee64262571620bdd10ad11..e305c18a60de69c2ac92c6fff06abd867cae4163 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
@@ -12,8 +12,6 @@ import 'service_ref.dart';
class InstanceRefElement extends ServiceRefElement {
InstanceRefElement.created() : super.created();
- @published bool expanded = false;
-
String get name {
if (ref == null) {
return super.name;
@@ -21,20 +19,27 @@ class InstanceRefElement extends ServiceRefElement {
return ref['preview'];
}
- void toggleExpand(var a, var b, var c) {
- if (expanded) {
- ref['fields'] = null;
- ref['elements'] = null;
- expanded = false;
- } else {
+ // TODO(turnidge): This is here to workaround vm/dart2js differences.
+ dynamic expander() {
+ return expandEvent;
+ }
+
+ void expandEvent(bool expand, var done) {
+ print("Calling expandEvent");
+ if (expand) {
app.requestManager.requestMap(url).then((map) {
+ print("Result is : $map");
ref['fields'] = map['fields'];
ref['elements'] = map['elements'];
ref['length'] = map['length'];
- expanded = true;
+ print("ref is $ref");
}).catchError((e, trace) {
Logger.root.severe('Error while expanding instance-ref: $e\n$trace');
- });
+ }).whenComplete(done);
+ } else {
+ ref['fields'] = null;
+ ref['elements'] = null;
+ done();
}
}
}

Powered by Google App Engine
This is Rietveld 408576698