[package:mdv] port createInstance change

[package:mdv] port createInstance change
HTMLTemplateElement.prototype.createInstance takes model & syntaxString, sets up bindings -- https://github.com/Polymer/mdv/commit/22c32ebfa84b6e08341b2e1af71a25b5bee4b2be

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24660

[Jennifer Messerly, 2013-06-28 01:11:05]

https://codereview.chromium.org/18162004/diff/1/pkg/mdv/lib/src/bindings.dart
File pkg/mdv/lib/src/bindings.dart (left):

https://codereview.chromium.org/18162004/diff/1/pkg/mdv/lib/src/bindings.dart...
pkg/mdv/lib/src/bindings.dart:139: class _Bindings {
this is simply removing the static class, as suggested in an earlier code
review.

also "syntax" is renamed to "delegate" if it is the delegate object.

https://codereview.chromium.org/18162004/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate (left):

https://codereview.chromium.org/18162004/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate:98:
getInstanceFragment(Element template) => template.createInstance();
I removed this for now. This was me jumping the gun and adding something I
thought would be useful for https://github.com/Polymer/mdv/issues/87

but it is hard to maintain an extension like this, while the "createInstance"
method is still in flux.

[Jennifer Messerly, 2013-06-28 18:57:09]

+Siggi

[Siggi Cherem (dart-lang), 2013-06-28 20:41:59]

lgtm

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.dart
File pkg/mdv/lib/src/bindings.dart (right):

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.d...
pkg/mdv/lib/src/bindings.dart:146: Node
_createDeepCloneAndDecorateTemplates(Node node, String syntax) {
other than indentation, did anything else change from here to 294?

[Jennifer Messerly, 2013-06-28 20:45:38]

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.dart
File pkg/mdv/lib/src/bindings.dart (right):

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.d...
pkg/mdv/lib/src/bindings.dart:146: Node
_createDeepCloneAndDecorateTemplates(Node node, String syntax) {
On 2013/06/28 20:42:00, Siggi Cherem (dart-lang) wrote:
> other than indentation, did anything else change from here to 294?

"syntax" was renamed to "delegate" if it's not a String in the MDV code, so I
made the change here

[Siggi Cherem (dart-lang), 2013-06-28 20:47:28]

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.dart
File pkg/mdv/lib/src/bindings.dart (right):

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.d...
pkg/mdv/lib/src/bindings.dart:146: Node
_createDeepCloneAndDecorateTemplates(Node node, String syntax) {
On 2013/06/28 20:45:39, John Messerly wrote:
> On 2013/06/28 20:42:00, Siggi Cherem (dart-lang) wrote:
> > other than indentation, did anything else change from here to 294?
> 
> "syntax" was renamed to "delegate" if it's not a String in the MDV code, so I
> made the change here

I see- will the type change too? (CustomBindingSyntaxDelegate?)

[Jennifer Messerly, 2013-06-28 20:48:48]

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.dart
File pkg/mdv/lib/src/bindings.dart (right):

https://codereview.chromium.org/18162004/diff/2001/pkg/mdv/lib/src/bindings.d...
pkg/mdv/lib/src/bindings.dart:146: Node
_createDeepCloneAndDecorateTemplates(Node node, String syntax) {
On 2013/06/28 20:47:28, Siggi Cherem (dart-lang) wrote:
> On 2013/06/28 20:45:39, John Messerly wrote:
> > On 2013/06/28 20:42:00, Siggi Cherem (dart-lang) wrote:
> > > other than indentation, did anything else change from here to 294?
> > 
> > "syntax" was renamed to "delegate" if it's not a String in the MDV code, so
I
> > made the change here
> 
> I see- will the type change too? (CustomBindingSyntaxDelegate?)

yeah I'll rename it once I catch up to the "bindingDelegate" change.
for now it is still exposed as TemplateElement.syntax.

[Jennifer Messerly, 2013-07-01 21:38:53]

Committed patchset #3 manually as r24660 (presubmit successful).