Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Side by Side Diff: pkg/mdv/lib/src/element.dart

Issue 18162004: [package:mdv] port createInstance change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merged Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/mdv/lib/src/bindings.dart ('k') | pkg/mdv/lib/src/template.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of mdv; 5 part of mdv;
6 6
7 /** Extensions to the [Element] API. */ 7 /** Extensions to the [Element] API. */
8 class _ElementExtension extends _NodeExtension { 8 class _ElementExtension extends _NodeExtension {
9 _ElementExtension(Element node) : super(node); 9 _ElementExtension(Element node) : super(node);
10 10
11 Element get node => super.node; 11 Element get node => super.node;
12 12
13 Map<String, StreamSubscription> _attributeBindings; 13 Map<String, StreamSubscription> _attributeBindings;
14 14
15 // TODO(jmesserly): should path be optional, and default to empty path? 15 // TODO(jmesserly): should path be optional, and default to empty path?
16 // It is used that way in at least one path in JS TemplateElement tests 16 // It is used that way in at least one path in JS TemplateElement tests
17 // (see "BindImperative" test in original JS code). 17 // (see "BindImperative" test in original JS code).
18 void bind(String name, model, String path) { 18 void bind(String name, model, String path) {
19 if (_attributeBindings == null) { 19 if (_attributeBindings == null) {
20 _attributeBindings = new Map<String, StreamSubscription>(); 20 _attributeBindings = new Map<String, StreamSubscription>();
21 } 21 }
22 22
23 node.xtag.attributes.remove(name); 23 node.xtag.attributes.remove(name);
24 24
25 var changed; 25 var changed;
26 if (name.endsWith('?')) { 26 if (name.endsWith('?')) {
27 name = name.substring(0, name.length - 1); 27 name = name.substring(0, name.length - 1);
28 28
29 changed = (value) { 29 changed = (value) {
30 if (_Bindings._toBoolean(value)) { 30 if (_toBoolean(value)) {
31 node.xtag.attributes[name] = ''; 31 node.xtag.attributes[name] = '';
32 } else { 32 } else {
33 node.xtag.attributes.remove(name); 33 node.xtag.attributes.remove(name);
34 } 34 }
35 }; 35 };
36 } else { 36 } else {
37 changed = (value) { 37 changed = (value) {
38 // TODO(jmesserly): escape value if needed to protect against XSS. 38 // TODO(jmesserly): escape value if needed to protect against XSS.
39 // See https://github.com/polymer-project/mdv/issues/58 39 // See https://github.com/polymer-project/mdv/issues/58
40 node.xtag.attributes[name] = value == null ? '' : '$value'; 40 node.xtag.attributes[name] = value == null ? '' : '$value';
(...skipping 15 matching lines...) Expand all
56 56
57 void unbindAll() { 57 void unbindAll() {
58 if (_attributeBindings != null) { 58 if (_attributeBindings != null) {
59 for (var binding in _attributeBindings.values) { 59 for (var binding in _attributeBindings.values) {
60 binding.cancel(); 60 binding.cancel();
61 } 61 }
62 _attributeBindings = null; 62 _attributeBindings = null;
63 } 63 }
64 } 64 }
65 } 65 }
OLDNEW
« no previous file with comments | « pkg/mdv/lib/src/bindings.dart ('k') | pkg/mdv/lib/src/template.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698