Issue 18147021: Fix type check elimination bug in code generator (issue 11792).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18147021: Fix type check elimination bug in code generator (issue 11792). (Closed)

Created:
7 years, 5 months ago by regis

Modified:
7 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, hausner

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix type check elimination bug in code generator (issue 11792). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24962

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/malformed_type_test.dart	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

regis

It is strange this bug did not show its ugly face earlier. Another cl (https://codereview.chromium.org/19030004/) ...

7 years, 5 months ago (2013-07-12 03:16:20 UTC) #1

regis

7 years, 5 months ago (2013-07-12 17:37:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r24962 (presubmit successful).