Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 18147021: Fix type check elimination bug in code generator (issue 11792). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 // Assignable check is skipped in FlowGraphBuilder, not here. 649 // Assignable check is skipped in FlowGraphBuilder, not here.
650 ASSERT(dst_type.IsMalformed() || 650 ASSERT(dst_type.IsMalformed() ||
651 (!dst_type.IsDynamicType() && !dst_type.IsObjectType())); 651 (!dst_type.IsDynamicType() && !dst_type.IsObjectType()));
652 // Preserve instantiator (R2) and its type arguments (R1). 652 // Preserve instantiator (R2) and its type arguments (R1).
653 __ PushList((1 << R1) | (1 << R2)); 653 __ PushList((1 << R1) | (1 << R2));
654 // A null object is always assignable and is returned as result. 654 // A null object is always assignable and is returned as result.
655 Label is_assignable, runtime_call; 655 Label is_assignable, runtime_call;
656 __ CompareImmediate(R0, reinterpret_cast<int32_t>(Object::null())); 656 __ CompareImmediate(R0, reinterpret_cast<int32_t>(Object::null()));
657 __ b(&is_assignable, EQ); 657 __ b(&is_assignable, EQ);
658 658
659 if (!FLAG_eliminate_type_checks) { 659 if (!FLAG_eliminate_type_checks || dst_type.IsMalformed()) {
660 // If type checks are not eliminated during the graph building then 660 // If type checks are not eliminated during the graph building then
661 // a transition sentinel can be seen here. 661 // a transition sentinel can be seen here.
662 __ CompareObject(R0, Object::transition_sentinel()); 662 __ CompareObject(R0, Object::transition_sentinel());
663 __ b(&is_assignable, EQ); 663 __ b(&is_assignable, EQ);
664 } 664 }
665 665
666 // Generate throw new TypeError() if the type is malformed. 666 // Generate throw new TypeError() if the type is malformed.
667 if (dst_type.IsMalformed()) { 667 if (dst_type.IsMalformed()) {
668 const Error& error = Error::Handle(dst_type.malformed_error()); 668 const Error& error = Error::Handle(dst_type.malformed_error());
669 const String& error_message = String::ZoneHandle( 669 const String& error_message = String::ZoneHandle(
(...skipping 1178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1848 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1848 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1849 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex)); 1849 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex));
1850 } 1850 }
1851 1851
1852 1852
1853 #undef __ 1853 #undef __
1854 1854
1855 } // namespace dart 1855 } // namespace dart
1856 1856
1857 #endif // defined TARGET_ARCH_ARM 1857 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698