Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1813053002: Disallow include_tags and exclude_tags in a test context. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disallow include_tags and exclude_tags in a test context. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/ad54edb0f53c8c854552b609b8bb82f506a69f65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M lib/src/runner/configuration/load.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 9 months ago (2016-03-17 21:06:49 UTC) #1
kevmoo
lgtm
4 years, 9 months ago (2016-03-17 21:12:42 UTC) #2
nweiz
4 years, 9 months ago (2016-03-17 22:11:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad54edb0f53c8c854552b609b8bb82f506a69f65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698