Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: lib/src/runner/configuration/load.dart

Issue 1813053002: Disallow include_tags and exclude_tags in a test context. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:io'; 5 import 'dart:io';
6 6
7 import 'package:boolean_selector/boolean_selector.dart'; 7 import 'package:boolean_selector/boolean_selector.dart';
8 import 'package:glob/glob.dart'; 8 import 'package:glob/glob.dart';
9 import 'package:path/path.dart' as p; 9 import 'package:path/path.dart' as p;
10 import 'package:source_span/source_span.dart'; 10 import 'package:source_span/source_span.dart';
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 /// runner-level configuration fields. 128 /// runner-level configuration fields.
129 Configuration _loadRunnerConfig() { 129 Configuration _loadRunnerConfig() {
130 if (!_runnerConfig) { 130 if (!_runnerConfig) {
131 _disallow("reporter"); 131 _disallow("reporter");
132 _disallow("pub_serve"); 132 _disallow("pub_serve");
133 _disallow("concurrency"); 133 _disallow("concurrency");
134 _disallow("platforms"); 134 _disallow("platforms");
135 _disallow("paths"); 135 _disallow("paths");
136 _disallow("filename"); 136 _disallow("filename");
137 _disallow("add_presets"); 137 _disallow("add_presets");
138 _disallow("include_tags");
139 _disallow("exclude_tags");
138 return Configuration.empty; 140 return Configuration.empty;
139 } 141 }
140 142
141 var reporter = _getString("reporter"); 143 var reporter = _getString("reporter");
142 if (reporter != null && !allReporters.contains(reporter)) { 144 if (reporter != null && !allReporters.contains(reporter)) {
143 _error('Unknown reporter "$reporter".', "reporter"); 145 _error('Unknown reporter "$reporter".', "reporter");
144 } 146 }
145 147
146 var pubServePort = _getInt("pub_serve"); 148 var pubServePort = _getInt("pub_serve");
147 var concurrency = _getInt("concurrency"); 149 var concurrency = _getInt("concurrency");
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 if (!_document.containsKey(field)) return; 335 if (!_document.containsKey(field)) return;
334 _error("$field isn't supported here.", field); 336 _error("$field isn't supported here.", field);
335 } 337 }
336 338
337 /// Throws a [SourceSpanFormatException] with [message] about [field]. 339 /// Throws a [SourceSpanFormatException] with [message] about [field].
338 void _error(String message, String field) { 340 void _error(String message, String field) {
339 throw new SourceSpanFormatException( 341 throw new SourceSpanFormatException(
340 message, _document.nodes[field].span, _source); 342 message, _document.nodes[field].span, _source);
341 } 343 }
342 } 344 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698