Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1809993003: Add a --no-precompile flag. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -92 lines) Patch
M lib/src/command/get.dart View 1 chunk +5 lines, -1 line 0 comments Download
M lib/src/command/upgrade.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M lib/src/entrypoint.dart View 9 chunks +124 lines, -89 lines 0 comments Download
M test/get/cache_transformed_dependency_test.dart View 1 2 chunks +108 lines, -0 lines 0 comments Download
A test/snapshot/no_precompile_test.dart View 1 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 9 months ago (2016-03-17 19:51:25 UTC) #1
Bob Nystrom
LGTM! https://codereview.chromium.org/1809993003/diff/1/test/get/cache_transformed_dependency_test.dart File test/get/cache_transformed_dependency_test.dart (right): https://codereview.chromium.org/1809993003/diff/1/test/get/cache_transformed_dependency_test.dart#newcode488 test/get/cache_transformed_dependency_test.dart:488: integration("doesn't delete a cache when an unrelated dependency ...
4 years, 9 months ago (2016-03-17 20:05:07 UTC) #2
nweiz
Code review changes
4 years, 9 months ago (2016-03-17 20:09:02 UTC) #3
nweiz
https://codereview.chromium.org/1809993003/diff/1/test/get/cache_transformed_dependency_test.dart File test/get/cache_transformed_dependency_test.dart (right): https://codereview.chromium.org/1809993003/diff/1/test/get/cache_transformed_dependency_test.dart#newcode488 test/get/cache_transformed_dependency_test.dart:488: integration("doesn't delete a cache when an unrelated dependency is ...
4 years, 9 months ago (2016-03-17 20:09:56 UTC) #4
nweiz
4 years, 9 months ago (2016-03-17 20:11:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c1405b945c6d818c8cfe78334e8d4b11fd913103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698