Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: test/get/cache_transformed_dependency_test.dart

Issue 1809993003: Add a --no-precompile flag. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/entrypoint.dart ('k') | test/snapshot/no_precompile_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/get/cache_transformed_dependency_test.dart
diff --git a/test/get/cache_transformed_dependency_test.dart b/test/get/cache_transformed_dependency_test.dart
index a1ab8c440d90e361e319a8ca067866f91413f02f..183f26f1fc7aff861f43b6208487a9d5bc1e1689 100644
--- a/test/get/cache_transformed_dependency_test.dart
+++ b/test/get/cache_transformed_dependency_test.dart
@@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'package:path/path.dart' as p;
import 'package:scheduled_test/scheduled_test.dart';
import '../descriptor.dart' as d;
@@ -417,6 +418,113 @@ main() {
d.nothing(".pub/deps/debug/foo")
]).validate();
});
+
+ group("with --no-precompile", () {
+ integration("doesn't cache a transformed dependency", () {
+ servePackages((builder) {
+ builder.serveRealPackage('barback');
+
+ builder.serve("foo", "1.2.3",
+ deps: {'barback': 'any'},
+ pubspec: {'transformers': ['foo']},
+ contents: [
+ d.dir("lib", [
+ d.file("transformer.dart", replaceTransformer("Hello", "Goodbye")),
+ d.file("foo.dart", "final message = 'Hello!';")
+ ])
+ ]);
+ });
+
+ d.appDir({"foo": "1.2.3"}).create();
+
+ pubGet(args: ["--no-precompile"], output: isNot(contains("Precompiled")));
+
+ d.nothing(p.join(appPath, ".pub")).validate();
+ });
+
+ integration("deletes the cache when the dependency is updated", () {
+ servePackages((builder) {
+ builder.serveRealPackage('barback');
+
+ builder.serve("foo", "1.2.3",
+ deps: {'barback': 'any'},
+ pubspec: {'transformers': ['foo']},
+ contents: [
+ d.dir("lib", [
+ d.file("transformer.dart", replaceTransformer("Hello", "Goodbye")),
+ d.file("foo.dart", "final message = 'Hello!';")
+ ])
+ ]);
+
+ builder.serve("foo", "1.2.4",
+ deps: {'barback': 'any'},
+ pubspec: {'transformers': ['foo']},
+ contents: [
+ d.dir("lib", [
+ d.file("transformer.dart", replaceTransformer("Hello", "See ya")),
+ d.file("foo.dart", "final message = 'Hello!';")
+ ])
+ ]);
+ });
+
+ d.appDir({"foo": "1.2.3"}).create();
+
+ pubGet(output: contains("Precompiled foo."));
+
+ d.dir(appPath, [
+ d.dir(".pub/deps/debug/foo/lib", [
+ d.file("foo.dart", "final message = 'Goodbye!';")
+ ])
+ ]).validate();
+
+ // Upgrade to the new version of foo.
+ d.appDir({"foo": "1.2.4"}).create();
+
+ pubGet(args: ["--no-precompile"], output: isNot(contains("Precompiled")));
+
+ d.nothing(p.join(appPath, ".pub/deps/debug/foo")).validate();
+ });
+
+ integration("doesn't delete a cache when an unrelated dependency is "
+ "updated", () {
+ servePackages((builder) {
+ builder.serveRealPackage('barback');
+
+ builder.serve("foo", "1.2.3",
+ deps: {'barback': 'any'},
+ pubspec: {'transformers': ['foo']},
+ contents: [
+ d.dir("lib", [
+ d.file("transformer.dart", replaceTransformer("Hello", "Goodbye")),
+ d.file("foo.dart", "final message = 'Hello!';")
+ ])
+ ]);
+
+ builder.serve("bar", "5.6.7");
+ });
+
+ d.appDir({"foo": "1.2.3"}).create();
+ pubGet(output: contains("Precompiled foo."));
+
+
+ d.dir(appPath, [
+ d.dir(".pub/deps/debug/foo/lib", [
+ d.file("foo.dart", "final message = 'Goodbye!';")
+ ])
+ ]).validate();
+
+ globalPackageServer.add((builder) => builder.serve("bar", "6.0.0"));
+ pubUpgrade(
+ args: ["--no-precompile"],
+ output: isNot(contains("Precompiled")));
+
+ d.dir(appPath, [
+ d.dir(".pub/deps/debug/foo/lib", [
+ d.file("foo.dart", "final message = 'Goodbye!';")
+ ])
+ ]).validate();
+ });
+ });
}
String replaceTransformer(String input, String output) {
« no previous file with comments | « lib/src/entrypoint.dart ('k') | test/snapshot/no_precompile_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698