Add FileException.path and clean up file exceptions.

Add FileException.path and clean up file exceptions.

Now correctly throw ArgumentError and not delayed FileExceptions in case
of invalid arguments.

BUG=https://code.google.com/p/dart/issues/detail?id=3075

Committed: https://code.google.com/p/dart/source/detail?r=24523

[Bill Hesse, 2013-06-27 16:32:45]

Very nice.  Looks good to me.

https://codereview.chromium.org/18090003/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/18090003/diff/1/sdk/lib/io/file_impl.dart#new...
sdk/lib/io/file_impl.dart:412: throwIfError(ms, "Cannot retrieve modification",
_path);
modification time

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_erro...
File tests/standalone/io/file_error_test.dart (right):

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_erro...
tests/standalone/io/file_error_test.dart:27: print(e);
Stray print statement.

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
File tests/standalone/io/file_invalid_arguments_test.dart (right):

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:21: var errors = 0;
Remove the unused errors var.

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:44: Expect.isTrue(e is
ArgumentError);
Why not 
Expect.throws(() => file.readInto(buffer, start, end),
             (e) => e is ArgumentError);
?

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:65: }
Expect.throws?

[Anders Johnsen, 2013-06-27 16:42:18]

https://codereview.chromium.org/18090003/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/18090003/diff/1/sdk/lib/io/file_impl.dart#new...
sdk/lib/io/file_impl.dart:412: throwIfError(ms, "Cannot retrieve modification",
_path);
On 2013/06/27 16:32:46, Bill Hesse wrote:
> modification time

Done.

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_erro...
File tests/standalone/io/file_error_test.dart (right):

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_erro...
tests/standalone/io/file_error_test.dart:27: print(e);
On 2013/06/27 16:32:46, Bill Hesse wrote:
> Stray print statement.

Done.

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
File tests/standalone/io/file_invalid_arguments_test.dart (right):

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:21: var errors = 0;
On 2013/06/27 16:32:46, Bill Hesse wrote:
> Remove the unused errors var.

Done.

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:44: Expect.isTrue(e is
ArgumentError);
On 2013/06/27 16:32:46, Bill Hesse wrote:
> Why not 
> Expect.throws(() => file.readInto(buffer, start, end),
>              (e) => e is ArgumentError);
> ?

Done.

https://codereview.chromium.org/18090003/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:65: }
On 2013/06/27 16:32:46, Bill Hesse wrote:
> Expect.throws?

Done.

[Anders Johnsen, 2013-06-27 16:42:43]

Committed patchset #2 manually as r24523 (presubmit successful).

[PhistucK, 2013-06-27 18:52:34]

On 2013/06/27 16:42:43, Anders Johnsen wrote:
> Committed patchset #2 manually as r24523 (presubmit successful).

FileException is going away. See https://codereview.chromium.org/17761003/ for
details.

[PhistucK, 2013-06-27 19:10:24]

On 2013/06/27 18:52:34, PhistucK wrote:
> On 2013/06/27 16:42:43, Anders Johnsen wrote:
> > Committed patchset #2 manually as r24523 (presubmit successful).
> 
> FileException is going away. See https://codereview.chromium.org/17761003/ for
> details.

Oops, thank you. Sorry!