Add FileException.path and clean up file exceptions.

tests/standalone/io/file_invalid_arguments_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:async";
 import "package:expect/expect.dart";
 import "dart:io";
 import "dart:isolate";
 
 void testReadInvalidArgs(arg) {
-  var port = new ReceivePort();
   String filename = getFilename("tests/vm/data/fixed_length_file");
   var file = (new File(filename)).openSync();
   try {
     file.readSync(arg);
     Expect.fail('exception expected');
   } catch (e) {
-    Expect.isTrue(e is FileException);
-    Expect.isTrue(e.toString().contains('Invalid arguments'));
+    Expect.isTrue(e is ArgumentError);
+    Expect.isTrue(e.toString().contains(arg.toString()));
   }
 
   var errors = 0;

[Bill Hesse, 2013/06/27 16:32:46]

Remove the unused errors var.

[Anders Johnsen, 2013/06/27 16:42:19]

Done.

-  var readFuture = file.read(arg);
-  readFuture.then((bytes) {
-    Expect.fail('exception expected');
-  }).catchError((error) {
-    errors++;
-    Expect.isTrue(error is FileException);
-    Expect.isTrue(error.toString().contains('Invalid arguments'));
-    file.close().then((ignore) {
-      Expect.equals(1, errors);
-      port.close();
-    });
-  });
+  try {
+    var readFuture = file.read(arg);
+  } catch (e) {
+    Expect.isTrue(e is ArgumentError);
+    Expect.isTrue(e.toString().contains(arg.toString()));
+  }
 }
 
 void testReadIntoInvalidArgs(buffer, start, end) {
-  var port = new ReceivePort();
   String filename = getFilename("tests/vm/data/fixed_length_file");
   var file = (new File(filename)).openSync();
   try {
     file.readIntoSync(buffer, start, end);
     Expect.fail('exception expected');
   } catch (e) {
-    Expect.isTrue(e is FileException);
-    Expect.isTrue(e.toString().contains('Invalid arguments'));
+    Expect.isTrue(e is ArgumentError);
   }
 
-  var errors = 0;
-  var readIntoFuture = file.readInto(buffer, start, end);
-  readIntoFuture.then((bytes) {
+  try {
+    file.readInto(buffer, start, end);
     Expect.fail('exception expected');
-  }).catchError((error) {
-    errors++;
-    Expect.isTrue(error is FileException);
-    Expect.isTrue(error.toString().contains('Invalid arguments'));
-    file.close().then((ignore) {
-      Expect.equals(1, errors);
-      port.close();
-    });
-  });
+  } catch (e) {
+    Expect.isTrue(e is ArgumentError);

[Bill Hesse, 2013/06/27 16:32:46]

Why not 
Expect.throws(() => file.readInto(buffer, start, end),
             (e) => e is ArgumentError);
?

[Anders Johnsen, 2013/06/27 16:42:19]

Done.

+  }
 }
 
 void testWriteByteInvalidArgs(value) {
-  var port = new ReceivePort();
   String filename = getFilename("tests/vm/data/fixed_length_file");
   var file = (new File("${filename}_out")).openSync(mode: FileMode.WRITE);
   try {
     file.writeByteSync(value);
     Expect.fail('exception expected');
   } catch (e) {
-    Expect.isTrue(e is FileException);
-    Expect.isTrue(e.toString().contains('Invalid argument'));
+    Expect.isTrue(e is ArgumentError);
+    Expect.isTrue(e.toString().contains(value.toString()));
   }
 
-  var writeByteFuture = file.writeByte(value);
-  writeByteFuture.then((ignore) {
+  try {
+    file.writeByte(value);
     Expect.fail('exception expected');
-  }).catchError((error) {
-    Expect.isTrue(error is FileException);
-    Expect.isTrue(error.toString().contains('Invalid argument'));
-    file.close().then((ignore) {
-      port.close();
-    });
-  });
+  } catch (e) {
+    Expect.isTrue(e is ArgumentError);
+    Expect.isTrue(e.toString().contains(value.toString()));
+  }

[Bill Hesse, 2013/06/27 16:32:46]

Expect.throws?

[Anders Johnsen, 2013/06/27 16:42:19]

Done.

 }
 
 void testWriteFromInvalidArgs(buffer, start, end) {
-  var port = new ReceivePort();
   String filename = getFilename("tests/vm/data/fixed_length_file");
   var file = (new File("${filename}_out")).openSync(mode: FileMode.WRITE);
   try {
     file.writeFromSync(buffer, start, end);
     Expect.fail('exception expected');
   } catch (e) {
-    Expect.isTrue(e is FileException);
-    Expect.isTrue(e.toString().contains('Invalid arguments'));
+    Expect.isTrue(e is ArgumentError);
   }
 
-  var writeFromFuture = file.writeFrom(buffer, start, end);
-  writeFromFuture.then((ignore) {
+  try {
+    file.writeFrom(buffer, start, end);
     Expect.fail('exception expected');
-  }).catchError((error) {
-    Expect.isTrue(error is FileException);
-    Expect.isTrue(error.toString().contains('Invalid arguments'));
-    file.close().then((ignore) {
-      port.close();
-    });
-  });
+  } catch (e) {
+    Expect.isTrue(e is ArgumentError);
+  }
 }
 
 void testWriteStringInvalidArgs(string, encoding) {
-  var port = new ReceivePort();
   String filename = getFilename("tests/vm/data/fixed_length_file");
   var file = new File("${filename}_out").openSync(mode: FileMode.WRITE);
   try {
     file.writeStringSync(string, encoding: encoding);
     Expect.fail('exception expected');
   } catch (e) {
-    Expect.isTrue(e is FileException);
+    Expect.isTrue(e is ArgumentError);
   }
 
-  var writeStringFuture = file.writeString(string, encoding: encoding);
-  writeStringFuture.then((ignore) {
+  try {
+    file.writeString(string, encoding: encoding);
     Expect.fail('exception expected');
-  }).catchError((error) {
-    Expect.isTrue(error is FileException);
-    file.close().then((ignore) {
-      port.close();
-    });
-  });
+  } catch (e) {
+    Expect.isTrue(e is ArgumentError);
+  }
 }
 
 Future futureThrows(Future result) {
   return result.then((value) {
     throw new ExpectException(
         "futureThrows received $value instead of an exception");
     },
     onError: (_) => null
   );
 }
@@ skipping 33 matching lines @@
   testReadIntoInvalidArgs(12, 0, 1);
   testReadIntoInvalidArgs(new List(10), '0', 1);
   testReadIntoInvalidArgs(new List(10), 0, '1');
   testWriteByteInvalidArgs('asdf');
   testWriteFromInvalidArgs(12, 0, 1);
   testWriteFromInvalidArgs(new List(10), '0', 1);
   testWriteFromInvalidArgs(new List(10), 0, '1');
   testWriteStringInvalidArgs("Hello, world", 42);
   testFileSystemEntity();
 }