Issue 18089011: Added named constructors to Element to construct common elements.

Issue 18089011: Added named constructors to Element to construct common elements. (Closed)

Created:
7 years, 5 months ago by Andrei Mouravski

Modified:
7 years, 5 months ago

Reviewers:
Emily Fortuna, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added named constructors to Element to construct common elements. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=24606

Patch Set 3 : Made tag names work correctly. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+435 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2	1 chunk	+145 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+145 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 2	1 chunk	+145 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/18089011/diff/1/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://codereview.chromium.org/18089011/diff/1/tools/dom/scripts/systemhtml.py#newcode583 tools/dom/scripts/systemhtml.py:583: # additional_methods = 'asdasdas' delete. https://codereview.chromium.org/18089011/diff/1/tools/dom/scripts/systemhtml.py#newcode592 tools/dom/scripts/systemhtml.py:592: " /// ...

7 years, 5 months ago (2013-06-28 00:28:11 UTC) #2

Andrei Mouravski

PTAL. https://codereview.chromium.org/18089011/diff/1/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://codereview.chromium.org/18089011/diff/1/tools/dom/scripts/systemhtml.py#newcode583 tools/dom/scripts/systemhtml.py:583: # additional_methods = 'asdasdas' On 2013/06/28 00:28:11, blois ...

7 years, 5 months ago (2013-06-28 19:19:21 UTC) #3

blois

lgtm https://codereview.chromium.org/18089011/diff/5001/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/18089011/diff/5001/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode265 tools/dom/templates/html/impl/impl_Element.darttemplate:265: /// This is identical to calling `new Element.tag(a)`. ...

7 years, 5 months ago (2013-06-28 20:07:59 UTC) #4

Andrei Mouravski

Thanks! Will submit in a sec. https://codereview.chromium.org/18089011/diff/5001/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/18089011/diff/5001/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode265 tools/dom/templates/html/impl/impl_Element.darttemplate:265: /// This is ...

7 years, 5 months ago (2013-06-28 20:31:17 UTC) #5

Andrei Mouravski

7 years, 5 months ago (2013-06-28 20:35:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r24606 (presubmit successful).

Expand Messages | Collapse Messages