Added named constructors to Element to construct common elements.

tools/dom/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 import logging
@@ skipping 307 matching lines @@
     return []
   infos = element_constructors[typename]
   if isinstance(infos, str):
     infos = ElementConstructorInfo(tag=infos,
         factory_provider_name=factory_provider_name)
   if not isinstance(infos, list):
     infos = [infos]
   return infos
 
 # ------------------------------------------------------------------------------
+
+_html_element_tags = [
+    # TODO(amouravski): add a custom factory constructor for h1..h6.
+    # TODO(amouravski): add a custom factory constructor for input
+    'a',
+    'article',
+    'aside',
+    'audio',
+    'br',
+    'canvas',
+    'div',
+    'footer',
+    'header',
+    'hr',
+    'iframe',
+    'img',
+    'li',
+    'nav',
+    'ol',
+    'option',
+    'p',
+    'pre',
+    'section',
+    'select',
+    'span',
+    'svg',
+    'table',
+    'td',
+    'textarea',
+    'th',
+    'tr',
+    'ul',
+    'video',
+]
+
+
+# ------------------------------------------------------------------------------
 def SvgSupportStr(tagName):
   return 'Svg%s' % ElemSupportStr(tagName)
 
 def ElemSupportStr(tagName):
   return "Element.isTagSupported('%s')" % tagName
 
 _js_support_checks_basic_element_with_constructors = [
   'HTMLContentElement',
   'HTMLDataListElement',
   'HTMLDetailsElement',
@@ skipping 198 matching lines @@
       if not base_class:
         base_class = 'Interceptor'
 
     annotations = self._metadata.GetFormattedMetadata(
         self._library_name, self._interface, None, '')
 
     class_modifiers = ''
     if self._renamer.ShouldSuppressInterface(self._interface):
       class_modifiers = 'abstract '
 
+#    additional_methods = 'asdasdas'

[blois, 2013/06/28 00:28:11]

delete.

[Andrei Mouravski, 2013/06/28 19:19:21]

Done.

+#    if self._interface.id == 'HTMLElement':
+#      additional_methods = ''.join(_ElementTagConstructors())
+
+    additional_methods = []
+    if self._interface.id in 'HTMLElement':
+      for tag in _html_element_tags:
+        method = (
+            "\n"
+            "  /// Creates a new `<{0}>` element.\n"

[blois, 2013/06/28 00:28:11]

Just put this into the template file.

[Andrei Mouravski, 2013/06/28 19:19:21]

I don't understand. Do you mean inline all of the static constructors? I mean,
there's a bunch of them.

Let me know if this is what you meant.

+            "  ///\n"
+            "  /// This is identical to calling `new Element.tag({0})`.\n"
+            "  factory Element.{0}() => new Element.tag({0});\n").format(tag)
+        additional_methods.append(method)
+    additional_str = ''.join(additional_methods)
+
     self._implementation_members_emitter = implementation_emitter.Emit(
         self._backend.ImplementationTemplate(),
         LIBRARYNAME='dart.dom.%s' % self._library_name,
         ANNOTATIONS=annotations,
         CLASS_MODIFIERS=class_modifiers,
         CLASSNAME=self._interface_type_info.implementation_name(),
         EXTENDS=' extends %s' % base_class if base_class else '',
         IMPLEMENTS=implements_str,
         MIXINS=mixins_str,
         DOMNAME=self._interface.doc_js_name,
-        NATIVESPEC=self._backend.NativeSpec())
+        NATIVESPEC=self._backend.NativeSpec(),
+        ADDITIONAL_METHODS=additional_str)
     self._backend.StartInterface(self._implementation_members_emitter)
 
     self._backend.EmitHelpers(base_class)
     self._event_generator.EmitStreamProviders(
         self._interface,
         self._backend.CustomJSMembers(),
         self._implementation_members_emitter,
         self._library_name)
     self._backend.AddConstructors(
         constructors, factory_provider, factory_constructor_name)
@@ skipping 621 matching lines @@
     for library_name in libraries:
       self._libraries[library_name] = DartLibrary(
           library_name, template_loader, library_type, output_dir)
 
   def AddFile(self, basename, library_name, path):
     self._libraries[library_name].AddFile(path)
 
   def Emit(self, emitter, auxiliary_dir):
     for lib in self._libraries.values():
       lib.Emit(emitter, auxiliary_dir)