Issue 18054006: Fix Random_nextState intrinsic on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18054006: Fix Random_nextState intrinsic on ARM. (Closed)

Created:
7 years, 5 months ago by regis

Modified:
7 years, 5 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -29 lines)			Patch
M	runtime/vm/assembler_arm.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View		2 chunks	+24 lines, -25 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

regis

Zach, The fix will be identical on MIPS. I let you do it :-) Thanks, ...

7 years, 5 months ago (2013-06-27 19:54:00 UTC) #1

zra

lgtm Thanks for catching that =) I'll take care of the mips side.

7 years, 5 months ago (2013-06-27 20:01:57 UTC) #2

regis

7 years, 5 months ago (2013-06-27 20:16:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24548 (presubmit successful).