Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 18054006: Fix Random_nextState intrinsic on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/disassembler_arm.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc (revision 24544)
+++ runtime/vm/intrinsifier_arm.cc (working copy)
@@ -1402,9 +1402,9 @@
__ LoadImmediate(R0, a_int32_value);
__ LoadFromOffset(kLoadWord, R2, R1, disp_0 - kHeapObjectTag);
__ LoadFromOffset(kLoadWord, R3, R1, disp_1 - kHeapObjectTag);
- __ mov(R6, ShifterOperand(R3, ASR, 31)); // Sign extend into R6.
- // 64-bit multiply and accumulate into R6:R3.
- __ smlal(R3, R6, R0, R2); // R6:R3 <- R6:R3 + R0 * R2.
+ __ mov(R6, ShifterOperand(0)); // Zero extend unsigned _state[kSTATE_HI].
+ // Unsigned 32-bit multiply and 64-bit accumulate into R6:R3.
+ __ umlal(R3, R6, R0, R2); // R6:R3 <- R6:R3 + R0 * R2.
__ StoreToOffset(kStoreWord, R3, R1, disp_0 - kHeapObjectTag);
__ StoreToOffset(kStoreWord, R6, R1, disp_1 - kHeapObjectTag);
__ Ret();
« no previous file with comments | « runtime/vm/disassembler_arm.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698