Issue 18031023: Remove _BufferList from dart:io and now use BytesBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18031023: Remove _BufferList from dart:io and now use BytesBuilder. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove _BufferList from dart:io and now use BytesBuilder. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24941

Patch Set 2 : Use takeBytes not toBytes. #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -158 lines)			Patch
M	runtime/bin/process_patch.dart	View	1	1 chunk	+2 lines, -7 lines	0 comments	Download
D	sdk/lib/io/buffer_list.dart	View		1 chunk	+0 lines, -100 lines	0 comments	Download
M	sdk/lib/io/bytes_builder.dart	View	1	1 chunk	+2 lines, -1 line	1 comment	Download
M	sdk/lib/io/file_impl.dart	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	sdk/lib/io/http_body_impl.dart	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/io/http_headers.dart	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1	7 chunks	+23 lines, -23 lines	0 comments	Download
M	sdk/lib/io/io.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/web_socket_protocol_processor_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/18031023/diff/2001/sdk/lib/io/bytes_builder.dart File sdk/lib/io/bytes_builder.dart (right): https://codereview.chromium.org/18031023/diff/2001/sdk/lib/io/bytes_builder.dart#newcode71 sdk/lib/io/bytes_builder.dart:71: return new Uint8List.view(buffer.buffer, 0, length); Very funny bug!

7 years, 5 months ago (2013-07-12 10:23:24 UTC) #2

Anders Johnsen

7 years, 5 months ago (2013-07-12 10:39:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24941 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18031023: Remove _BufferList from dart:io and now use BytesBuilder. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use takeBytes not toBytes. #

Messages