Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: sdk/lib/io/http_headers.dart

Issue 18031023: Remove _BufferList from dart:io and now use BytesBuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use takeBytes not toBytes. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/http_headers.dart
diff --git a/sdk/lib/io/http_headers.dart b/sdk/lib/io/http_headers.dart
index 342755b757d096c65b9b29861e14122ee74cf808..eec66c699509e709139e29eb73003d5e7da2ef30 100644
--- a/sdk/lib/io/http_headers.dart
+++ b/sdk/lib/io/http_headers.dart
@@ -344,7 +344,7 @@ class _HttpHeaders implements HttpHeaders {
_mutable = false;
}
- _write(_BufferList buffer) {
+ _write(BytesBuilder builder) {
final COLONSP = const [_CharCode.COLON, _CharCode.SP];
final COMMASP = const [_CharCode.COMMA, _CharCode.SP];
final CRLF = const [_CharCode.CR, _CharCode.LF];
@@ -353,21 +353,21 @@ class _HttpHeaders implements HttpHeaders {
_headers.forEach((String name, List<String> values) {
bool fold = _foldHeader(name);
var nameData = name.codeUnits;
- buffer.add(nameData);
- buffer.add(const [_CharCode.COLON, _CharCode.SP]);
+ builder.add(nameData);
+ builder.add(const [_CharCode.COLON, _CharCode.SP]);
for (int i = 0; i < values.length; i++) {
if (i > 0) {
if (fold) {
- buffer.add(const [_CharCode.COMMA, _CharCode.SP]);
+ builder.add(const [_CharCode.COMMA, _CharCode.SP]);
} else {
- buffer.add(const [_CharCode.CR, _CharCode.LF]);
- buffer.add(nameData);
- buffer.add(const [_CharCode.COLON, _CharCode.SP]);
+ builder.add(const [_CharCode.CR, _CharCode.LF]);
+ builder.add(nameData);
+ builder.add(const [_CharCode.COLON, _CharCode.SP]);
}
}
- buffer.add(values[i].codeUnits);
+ builder.add(values[i].codeUnits);
}
- buffer.add(const [_CharCode.CR, _CharCode.LF]);
+ builder.add(const [_CharCode.CR, _CharCode.LF]);
});
}

Powered by Google App Engine
This is Rietveld 408576698