Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 18029023: Add a couple functions to package:stack_trace. (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a couple functions to package:stack_trace. This adds a function to convert a Trace to a VM-style StackTrace object, and to parse a Trace-style string into a Trace. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=24611

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -37 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 2 chunks +25 lines, -0 lines 0 comments Download
M pkg/stack_trace/lib/src/lazy_trace.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 1 5 chunks +17 lines, -27 lines 0 comments Download
A pkg/stack_trace/lib/src/utils.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/stack_trace/lib/src/vm_trace.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 2 chunks +28 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 5 months ago (2013-06-28 20:46:58 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/18029023/diff/1/pkg/stack_trace/lib/src/utils.dart File pkg/stack_trace/lib/src/utils.dart (right): https://codereview.chromium.org/18029023/diff/1/pkg/stack_trace/lib/src/utils.dart#newcode5 pkg/stack_trace/lib/src/utils.dart:5: library utils; do we still have an issue ...
7 years, 5 months ago (2013-06-28 21:48:07 UTC) #2
nweiz
https://codereview.chromium.org/18029023/diff/1/pkg/stack_trace/lib/src/utils.dart File pkg/stack_trace/lib/src/utils.dart (right): https://codereview.chromium.org/18029023/diff/1/pkg/stack_trace/lib/src/utils.dart#newcode5 pkg/stack_trace/lib/src/utils.dart:5: library utils; On 2013/06/28 21:48:07, John Messerly wrote: > ...
7 years, 5 months ago (2013-06-28 22:23:54 UTC) #3
nweiz
7 years, 5 months ago (2013-06-28 22:24:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698