Check that non-abstract classes implement all methods.

Check that non-abstract classes implement all methods.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30859

[Johnni Winther, 2013-12-04 12:09:14]

lgtm

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:925:
superclass.forEachMember((ClassElement holder, Element member) {
Add TODO that we need to handle setter vs. getter override correctly.

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1381: main() => new
C().m();
We should getter the warning without calling m.

https://codereview.chromium.org/18029018/diff/2001/dart/tests/compiler/dart2j...
File dart/tests/compiler/dart2js/analyze_api_test.dart (right):

https://codereview.chromium.org/18029018/diff/2001/dart/tests/compiler/dart2j...
dart/tests/compiler/dart2js/analyze_api_test.dart:23:
"sdk/lib/_collection_dev/iterable.dart": const [
Where do these infos come from?

[ahe, 2013-12-04 16:13:44]

Thank you, Johnni!

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:925:
superclass.forEachMember((ClassElement holder, Element member) {
On 2013/12/04 12:09:14, Johnni Winther wrote:
> Add TODO that we need to handle setter vs. getter override correctly.

I'd argue that this code would just work correctly if we get rid of abstract
fields and instead make sure to induce getters and setters for real fields.

So I didn't add a TODO here.

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/18029018/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1381: main() => new
C().m();
On 2013/12/04 12:09:14, Johnni Winther wrote:
> We should getter the warning without calling m.

No, but we do get a warning that it is never called which makes the test fail.

So I added another class D and made sure to invoke m on an instance of D.

https://codereview.chromium.org/18029018/diff/2001/dart/tests/compiler/dart2j...
File dart/tests/compiler/dart2js/analyze_api_test.dart (right):

https://codereview.chromium.org/18029018/diff/2001/dart/tests/compiler/dart2j...
dart/tests/compiler/dart2js/analyze_api_test.dart:23:
"sdk/lib/_collection_dev/iterable.dart": const [
On 2013/12/04 12:09:14, Johnni Winther wrote:
> Where do these infos come from?

After saying which method isn't implemented, dart2js emits a hint pointing to
the abstract element. Explained in comment.

[ahe, 2013-12-04 17:17:37]

Committed patchset #2 manually as r30859 (presubmit successful).