Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: dart/sdk/lib/_internal/lib/isolate_helper.dart

Issue 18029018: Check that non-abstract classes implement all methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/lib/constant_map.dart ('k') | dart/sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/lib/isolate_helper.dart
diff --git a/dart/sdk/lib/_internal/lib/isolate_helper.dart b/dart/sdk/lib/_internal/lib/isolate_helper.dart
index 474d6af8c7727dbf0db6163a2e22add8ddec6601..0ff30963cf5ce0b55e91ab16440e251e17e6fe76 100644
--- a/dart/sdk/lib/_internal/lib/isolate_helper.dart
+++ b/dart/sdk/lib/_internal/lib/isolate_helper.dart
@@ -703,7 +703,7 @@ class IsolateNatives {
********************************************************/
/** Common functionality to all send ports. */
-class _BaseSendPort implements SendPort {
+abstract class _BaseSendPort implements SendPort {
/** Id for the destination isolate. */
final int _isolateId;
@@ -1216,6 +1216,7 @@ class _Copier extends _MessageTraverser {
return copy;
}
+ visitSendPort(SendPort x) => throw new UnimplementedError();
}
/** Visitor that serializes a message as a JSON array. */
@@ -1257,6 +1258,8 @@ class _Serializer extends _MessageTraverser {
}
return result;
}
+
+ visitSendPort(SendPort x) => throw new UnimplementedError();
}
/** Deserializes arrays created with [_Serializer]. */
« no previous file with comments | « dart/sdk/lib/_internal/lib/constant_map.dart ('k') | dart/sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698