Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17977002: - Remove arguments definition test from the VM. (Closed)

Created:
7 years, 6 months ago by Ivan Posva
Modified:
7 years, 5 months ago
Reviewers:
regis, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Remove arguments definition test from the VM. - Update tests still referring to it. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24539

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -928 lines) Patch
M runtime/vm/ast.h View 1 2 2 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/ast_printer.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 2 chunks +1 line, -18 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 2 chunks +0 lines, -37 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
M runtime/vm/parser.h View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 5 chunks +1 line, -179 lines 0 comments Download
M runtime/vm/scopes.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tests/corelib/apply_test.dart View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M tests/corelib/iterable_join_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/list_fill_range_test.dart View 1 2 1 chunk +1 line, -5 lines 0 comments Download
D tests/language/argument_definition2_test.dart View 1 2 1 chunk +0 lines, -82 lines 0 comments Download
D tests/language/argument_definition3_test.dart View 1 2 1 chunk +0 lines, -78 lines 0 comments Download
D tests/language/argument_definition4_test.dart View 1 2 1 chunk +0 lines, -82 lines 0 comments Download
D tests/language/argument_definition5_test.dart View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/argument_definition6_test.dart View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M tests/language/argument_definition_test.dart View 1 2 1 chunk +6 lines, -68 lines 0 comments Download
M tests/language/constructor8_test.dart View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M tests/language/optional_named_parameters_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
7 years, 6 months ago (2013-06-27 00:25:51 UTC) #1
regis
LGTM At scopes.cc:285, you could remove this comment: // The saved arguments descriptor variable is ...
7 years, 6 months ago (2013-06-27 01:06:27 UTC) #2
Ivan Posva
Thanks! -ip https://codereview.chromium.org/17977002/diff/25001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (left): https://codereview.chromium.org/17977002/diff/25001/runtime/vm/flow_graph_builder.cc#oldcode3120 runtime/vm/flow_graph_builder.cc:3120: int num_params = function.NumParameters(); On 2013/06/27 01:06:27, ...
7 years, 5 months ago (2013-06-27 18:36:44 UTC) #3
Ivan Posva
7 years, 5 months ago (2013-06-27 18:38:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r24539 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698