Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 17977002: - Remove arguments definition test from the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 24537)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -1813,17 +1813,6 @@
}
-void EffectGraphVisitor::VisitArgumentDefinitionTestNode(
- ArgumentDefinitionTestNode* node) {
- InlineBailout("EffectGraphVisitor::VisitArgumentDefinitionTestNode");
- Definition* load = BuildLoadLocal(node->saved_arguments_descriptor());
- Value* arguments_descriptor = Bind(load);
- ArgumentDefinitionTestInstr* arg_def_test =
- new ArgumentDefinitionTestInstr(node, arguments_descriptor);
- ReturnDefinition(arg_def_test);
-}
-
-
intptr_t EffectGraphVisitor::GetCurrentTempLocalIndex() const {
return kFirstLocalSlotFromFp
- owner()->num_stack_locals()
@@ -3117,15 +3106,9 @@
if (node == owner()->parsed_function()->node_sequence()) {
ASSERT(scope->context_level() == 1);
const Function& function = owner()->parsed_function()->function();
- int num_params = function.NumParameters();
+ const int num_params = function.NumParameters();
int param_frame_index = (num_params == function.num_fixed_parameters()) ?
(kParamEndSlotFromFp + num_params) : kFirstLocalSlotFromFp;
- // Handle the saved arguments descriptor as an additional parameter.
- if (owner()->parsed_function()->GetSavedArgumentsDescriptorVar() !=
- NULL) {
- ASSERT(param_frame_index == kFirstLocalSlotFromFp);
- num_params++;
- }
for (int pos = 0; pos < num_params; param_frame_index--, pos++) {
const LocalVariable& parameter = *scope->VariableAt(pos);
ASSERT(parameter.owner() == scope);
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698