Issue 17907005: Implements external array access for mips.

Issue 17907005: Implements external array access for mips. (Closed)

Created:
7 years, 6 months ago by zra

Modified:
7 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implements external array access for mips. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24524

Patch Set 5 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -143 lines)			Patch
M	runtime/vm/assembler_mips.h	View	1 2 3 4	1 chunk	+20 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4	2 chunks	+61 lines, -64 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4	4 chunks	+111 lines, -66 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1 2 3 4	1 chunk	+10 lines, -2 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 2 3 4	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM Nice. Thanks! https://codereview.chromium.org/17907005/diff/4001/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://codereview.chromium.org/17907005/diff/4001/runtime/vm/intermediate_language_mips.cc#newcode1142 runtime/vm/intermediate_language_mips.cc:1142: __ lw(result, FieldAddress(object, offset())); On ARM, ...

7 years, 6 months ago (2013-06-27 01:34:04 UTC) #2

zra

https://codereview.chromium.org/17907005/diff/4001/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://codereview.chromium.org/17907005/diff/4001/runtime/vm/intermediate_language_mips.cc#newcode1142 runtime/vm/intermediate_language_mips.cc:1142: __ lw(result, FieldAddress(object, offset())); On 2013/06/27 01:34:04, regis wrote: ...

7 years, 5 months ago (2013-06-27 16:20:12 UTC) #3

zra

7 years, 5 months ago (2013-06-27 16:42:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r24524 (presubmit successful).

Expand Messages | Collapse Messages