Issue 17848003: dart:io | Add rename to Link

Issue 17848003: dart:io | Add rename to Link (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Add rename to Link R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24468

Patch Set 3 : Addressed review commetns #

Patch Set 4 : Another test fix #

Patch Set 5 : Fix again #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -10 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/file.cc	View		3 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/bin/file_android.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View		1 chunk	+17 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/io/file_impl.dart	View		2 chunks	+7 lines, -4 lines	0 comments	Download
M	sdk/lib/io/link.dart	View		2 chunks	+41 lines, -0 lines	0 comments	Download
M	tests/standalone/io/link_async_test.dart	View	1 2	2 chunks	+39 lines, -0 lines	0 comments	Download
M	tests/standalone/io/link_test.dart	View	1 2 3 4	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/17848003/diff/2001/sdk/lib/io/file_impl.dart File sdk/lib/io/file_impl.dart (right): https://codereview.chromium.org/17848003/diff/2001/sdk/lib/io/file_impl.dart#newcode338 sdk/lib/io/file_impl.dart:338: external static _renameLink(String oldPath, String newPath); I think ...

7 years, 6 months ago (2013-06-26 12:03:54 UTC) #2

Søren Gjesse

https://codereview.chromium.org/17848003/diff/2001/sdk/lib/io/file_impl.dart File sdk/lib/io/file_impl.dart (right): https://codereview.chromium.org/17848003/diff/2001/sdk/lib/io/file_impl.dart#newcode338 sdk/lib/io/file_impl.dart:338: external static _renameLink(String oldPath, String newPath); On 2013/06/26 12:03:54, ...

7 years, 6 months ago (2013-06-26 13:59:40 UTC) #3

Søren Gjesse

7 years, 6 months ago (2013-06-26 14:10:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r24468 (presubmit successful).

Expand Messages | Collapse Messages