dart:io | Add rename to Link

tests/standalone/io/link_async_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import "dart:async";
 import "dart:io";
 import "dart:isolate";
 
 // Test the dart:io Link class.
@@ skipping 146 matching lines @@
     .then((_) => new Directory.fromPath(base.append('a'))
         .list(recursive: true, followLinks: true).last)
     // This directory listing must terminate, even though it contains loops.
     .then((_) => new Directory.fromPath(base.append('a/b/c'))
         .list(recursive: true, followLinks: true).last)
     .then((_) => new Directory.fromPath(base).delete(recursive: true))
   );
 }
 
 
+Future testRename() {
+  Future testRename(Path base, String target) {
+    Link link1;
+    Link link2;
+    return new Link.fromPath(base.append('c')).create(target)
+        .then((link) {
+          link1 = link;
+          Expect.isTrue(link1.existsSync());
+          return link1.rename(base.append('d').toNativePath());
+        })
+        .then((link) {
+          link2 = link;
+          Expect.isFalse(link1.existsSync());
+          Expect.isTrue(link2.existsSync());
+          return link2.delete();
+        })
+        .then((_) => Expect.isFalse(link2.existsSync()));
+  }
+
+  return new Directory('').createTemp()
+      .then((baseDir) {
+          Path base = new Path(baseDir.path);
+          var targetsFutures = [];
+          targetsFutures.add(new Directory.fromPath(base.append('a')).create());
+          if (Platform.isWindows) {
+            // Currently only links to directories are supported on Windows.
+            targetsFutures.add(
+                new Directory.fromPath(base.append('b')).create());
+          } else {
+            targetsFutures.add(new File.fromPath(base.append('b')).create());
+          }
+          return Future.wait(targetsFutures)
+              .then((targets) {
+                  return testRename(base, targets[0].path)
+                      .then((_) => testRename(base, targets[1].path))

[Bill Hesse, 2013/06/26 12:03:54]

Don't we indent zero on a .then?

And actually, the "return" should only be indented 2, right?

Maybe the first .then((targets) { could be on the previous line.

[Søren Gjesse, 2013/06/26 13:59:40]

Done.

+                      .then((_) => baseDir.delete(recursive: true));
+                });
+      });
+}
+
 Future testDirectoryListing(Path base, Directory baseDir) {
   Map makeExpected(bool recursive, bool followLinks) {
     Map expected = new Map();
     expected['target'] = 'Directory';
     expected['link'] = followLinks ? 'Directory' : 'Link';
     if (recursive) {
       expected['target/createdDirectly'] = 'Directory';
       expected['target/createdThroughLink'] = 'Directory';
       expected['target/createdFile'] = 'File';
       if (followLinks) {
@@ skipping 35 matching lines @@
       );
     }
   }
   return Future.wait(futures);
 }
 
 main() {
   ReceivePort keepAlive = new ReceivePort();
   testCreate()
   .then((_) => testCreateLoopingLink())
+  .then((_) => testRename())
   .then((_) => keepAlive.close());
 }