Issue 17842003: Avoid picking port 65535 for ServerSockets, when any is requested.

Issue 17842003: Avoid picking port 65535 for ServerSockets, when any is requested. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
Søren Thygesen Gjesse, ricow1, Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid picking port 65535 for ServerSockets, when any is requested. Some browsers block requests to 65535. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24471

Patch Set 1 #

Total comments: 4

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -1 line)			Patch
M	runtime/bin/socket_android.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1 chunk	+11 lines, -0 lines	4 comments	Download
M	runtime/bin/socket_win.cc	View	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r24471 (presubmit successful).

7 years, 6 months ago (2013-06-26 15:13:05 UTC) #4

Ivan Posva

https://codereview.chromium.org/17842003/diff/1/runtime/bin/socket_macos.cc File runtime/bin/socket_macos.cc (right): https://codereview.chromium.org/17842003/diff/1/runtime/bin/socket_macos.cc#newcode328 runtime/bin/socket_macos.cc:328: // port. This comment is not clear. What you ...

7 years, 6 months ago (2013-06-27 01:08:55 UTC) #5

Anders Johnsen

7 years, 5 months ago (2013-06-27 16:35:57 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/17842003/diff/1/runtime/bin/socket_macos.cc
File runtime/bin/socket_macos.cc (right):

https://codereview.chromium.org/17842003/diff/1/runtime/bin/socket_macos.cc#n...
runtime/bin/socket_macos.cc:328: // port.
On 2013/06/27 01:08:55, Ivan Posva wrote:
> This comment is not clear. What you probably want to say is:
> // Don't close the socket until we have created a new socket, ensuring that we
> do not get the bad port number again.

https://codereview.chromium.org/18087003/

https://codereview.chromium.org/17842003/diff/1/runtime/bin/socket_macos.cc#n...
runtime/bin/socket_macos.cc:331: TEMP_FAILURE_RETRY(close(fd));
On 2013/06/27 01:08:55, Ivan Posva wrote:
> VOID_TEMP_FAILURE_RETRY

I can see you committed this. Thanks.

Expand Messages | Collapse Messages