Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: runtime/bin/socket_linux.cc

Issue 17842003: Avoid picking port 65535 for ServerSockets, when any is requested. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/socket_linux.cc
diff --git a/runtime/bin/socket_linux.cc b/runtime/bin/socket_linux.cc
index 3f9747596419b91dcf638c8664f135611f4b93b0..1aaba00aced5b47147a15e3fe6a315e07f50da75 100644
--- a/runtime/bin/socket_linux.cc
+++ b/runtime/bin/socket_linux.cc
@@ -322,6 +322,17 @@ intptr_t ServerSocket::CreateBindListen(RawAddr addr,
return -1;
}
+ // Test for invalid socket port 65535 (some browsers disallow it).
+ if (port == 0 && Socket::GetPort(fd) == 65535) {
+ // Don't close fd until we have created new. By doing that we ensure another
+ // port.
+ intptr_t new_fd = CreateBindListen(addr, 0, backlog, v6_only);
+ int err = errno;
+ TEMP_FAILURE_RETRY(close(fd));
+ errno = err;
+ return new_fd;
+ }
+
if (TEMP_FAILURE_RETRY(listen(fd, backlog > 0 ? backlog : SOMAXCONN)) != 0) {
TEMP_FAILURE_RETRY(close(fd));
return -1;

Powered by Google App Engine
This is Rietveld 408576698