Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17825002: Remove support for 'argument definitions test' from dart2js. (Closed)

Created:
7 years, 6 months ago by kasperl
Modified:
7 years, 6 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Remove support for 'argument definitions test' from dart2js. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24455

Patch Set 1 #

Patch Set 2 : Remove newline. #

Total comments: 3

Patch Set 3 : Remove SentinelConstant. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -252 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/constants.dart View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/util.dart View 4 chunks +10 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 4 chunks +0 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 7 chunks +1 line, -96 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 2 chunks +6 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 chunks +7 lines, -0 lines 0 comments Download
D tests/compiler/dart2js_extra/argument_definition_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kasperl
7 years, 6 months ago (2013-06-26 07:21:30 UTC) #1
kasperl
This is the dart2js companion to https://codereview.chromium.org/17765003/.
7 years, 6 months ago (2013-06-26 07:23:59 UTC) #2
ngeoffray
LGTM https://codereview.chromium.org/17825002/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/17825002/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode2864 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2864: compiler.enqueuer.resolution.getCachedElements(element); Remove calleeElements. https://codereview.chromium.org/17825002/diff/3001/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/17825002/diff/3001/tests/corelib/corelib.status#newcode57 ...
7 years, 6 months ago (2013-06-26 07:54:55 UTC) #3
ngeoffray
On 2013/06/26 07:54:55, ngeoffray wrote: > LGTM > > https://codereview.chromium.org/17825002/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart > File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): > ...
7 years, 6 months ago (2013-06-26 07:56:22 UTC) #4
kasperl
Thanks for the review! https://codereview.chromium.org/17825002/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/17825002/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode2864 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2864: compiler.enqueuer.resolution.getCachedElements(element); On 2013/06/26 07:54:55, ngeoffray ...
7 years, 6 months ago (2013-06-26 07:57:26 UTC) #5
kasperl
7 years, 6 months ago (2013-06-26 08:02:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r24455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698