Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

Issue 17825002: Remove support for 'argument definitions test' from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove SentinelConstant. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart
index c3cff04c73932dca47aed52636e49f0918d23956..ace154a497833dbe25791671a28824c10e9681d5 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart
@@ -61,10 +61,6 @@ class ConstantReferenceEmitter implements ConstantVisitor<jsAst.Expression> {
return constant.accept(this);
}
- jsAst.Expression visitSentinel(SentinelConstant constant) {
- return new jsAst.VariableUse(namer.CURRENT_ISOLATE);
- }
-
jsAst.Expression visitFunction(FunctionConstant constant) {
return new jsAst.VariableUse(
namer.isolateStaticClosureAccess(constant.element));
@@ -173,11 +169,6 @@ class ConstantInitializerEmitter implements ConstantVisitor<jsAst.Expression> {
return referenceEmitter.generateInInitializationContext(constant);
}
- jsAst.Expression visitSentinel(SentinelConstant constant) {
- compiler.internalError(
- "The parameter sentinel constant does not need specific JS code");
- }
-
jsAst.Expression visitFunction(FunctionConstant constant) {
compiler.internalError(
"The function constant does not need specific JS code");

Powered by Google App Engine
This is Rietveld 408576698