Don't report hasTerminal, if term-size is (0,0).

Don't report hasTerminal, if term-size is (0,0).

BUG=http://code.google.com/p/dart/issues/detail?id=17070
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33202

[Søren Gjesse, 2014-02-25 07:58:34]

lgtm, with comments

https://codereview.chromium.org/177863010/diff/1/runtime/bin/stdio_android.cc
File runtime/bin/stdio_android.cc (right):

https://codereview.chromium.org/177863010/diff/1/runtime/bin/stdio_android.cc...
runtime/bin/stdio_android.cc:68: struct winsize w;
What is the exact situation here? If there are situations where (0,0) is
expected in some situations please document when and why.

[Anders Johnsen, 2014-02-25 08:20:47]

https://codereview.chromium.org/177863010/diff/1/runtime/bin/stdio_android.cc
File runtime/bin/stdio_android.cc (right):

https://codereview.chromium.org/177863010/diff/1/runtime/bin/stdio_android.cc...
runtime/bin/stdio_android.cc:68: struct winsize w;
On 2014/02/25 07:58:34, Søren Gjesse wrote:
> What is the exact situation here? If there are situations where (0,0) is
> expected in some situations please document when and why.

From reading around the web, I found that it can return 0,0, and people use that
as a measure as well, to identify if there is a valid and sane terminal or not.

[Søren Gjesse, 2014-03-03 09:24:40]

On 2014/02/25 08:20:47, Anders Johnsen wrote:
> https://codereview.chromium.org/177863010/diff/1/runtime/bin/stdio_android.cc
> File runtime/bin/stdio_android.cc (right):
> 
>
https://codereview.chromium.org/177863010/diff/1/runtime/bin/stdio_android.cc...
> runtime/bin/stdio_android.cc:68: struct winsize w;
> On 2014/02/25 07:58:34, Søren Gjesse wrote:
> > What is the exact situation here? If there are situations where (0,0) is
> > expected in some situations please document when and why.
> 
> From reading around the web, I found that it can return 0,0, and people use
that
> as a measure as well, to identify if there is a valid and sane terminal or
not.

Any reason this has not landed?

[Anders Johnsen, 2014-03-03 10:17:10]

Committed patchset #1 manually as r33202 (presubmit successful).