Don't report hasTerminal, if term-size is (0,0).

runtime/bin/stdio_android.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include <errno.h>  // NOLINT
 #include <sys/ioctl.h>  // NOLINT
 #include <termios.h>  // NOLINT
@@ skipping 47 matching lines @@
   if (enabled) {
     term.c_lflag |= ICANON;
   } else {
     term.c_lflag &= ~(ICANON);
   }
   tcsetattr(STDIN_FILENO, TCSANOW, &term);
 }
 
 
 bool Stdout::GetTerminalSize(int size[2]) {
   struct winsize w;

[Søren Gjesse, 2014/02/25 07:58:34]

What is the exact situation here? If there are situations where (0,0) is
expected in some situations please document when and why.

[Anders Johnsen, 2014/02/25 08:20:47]

From reading around the web, I found that it can return 0,0, and people use that
as a measure as well, to identify if there is a valid and sane terminal or not.

   if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-        ioctl(STDOUT_FILENO, TIOCGWINSZ, &w) != 0)) {
-    return false;
+        ioctl(STDOUT_FILENO, TIOCGWINSZ, &w) == 0) &&
+      (w.ws_col != 0 || w.ws_row != 0)) {
+    size[0] = w.ws_col;
+    size[1] = w.ws_row;
+    return true;
   }
-  size[0] = w.ws_col;
-  size[1] = w.ws_row;
-  return true;
+  return false;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)