Add support for V8 and Firefox stack traces in pkg/stack_trace.

Add support for V8 and Firefox stack traces in pkg/stack_trace.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24502

[Bob Nystrom, 2013-06-26 17:01:05]

Couple of nits then LGTM.

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status#newcode60
pkg/pkg.status:60: stack_trace/test/dartium_test: Fail # Dartium-specific traces
Would "Skip" or "Fail, OK" be better here?

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/fr...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/fr...
pkg/stack_trace/lib/src/frame.dart:19:
r'^([^@(/]*)(?:\(.*\))?(/[^<]*<)?(?:\(.*\))?@(.*):(\d+)$');
Can you give an example for each of these?

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/tr...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/tr...
pkg/stack_trace/lib/src/trace.dart:15: final _firefoxTrace = new
RegExp(r"^[.0-9A-Za-z_$]*@");
Document what this is for and an example of what this matches.

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/darti...
File pkg/stack_trace/test/dartium_test.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/darti...
pkg/stack_trace/test/dartium_test.dart:61: test('with no argument returns a
trace starting at the current frame', () {
Long line.

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/vm_te...
File pkg/stack_trace/test/vm_test.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/vm_te...
pkg/stack_trace/test/vm_test.dart:61: test('with no argument returns a trace
starting at the current frame', () {
long line

[nweiz, 2013-06-26 20:08:01]

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status#newcode60
pkg/pkg.status:60: stack_trace/test/dartium_test: Fail # Dartium-specific traces
On 2013/06/26 17:01:05, Bob Nystrom wrote:
> Would "Skip" or "Fail, OK" be better here?

I don't think we want to skip, since if this ever succeeds something unexpected
is going on. I'm not sure what the difference between "Fail" and "Fail, OK" is.

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/fr...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/fr...
pkg/stack_trace/lib/src/frame.dart:19:
r'^([^@(/]*)(?:\(.*\))?(/[^<]*<)?(?:\(.*\))?@(.*):(\d+)$');
On 2013/06/26 17:01:05, Bob Nystrom wrote:
> Can you give an example for each of these?

Done.

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/tr...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/lib/src/tr...
pkg/stack_trace/lib/src/trace.dart:15: final _firefoxTrace = new
RegExp(r"^[.0-9A-Za-z_$]*@");
On 2013/06/26 17:01:05, Bob Nystrom wrote:
> Document what this is for and an example of what this matches.

Done.

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/darti...
File pkg/stack_trace/test/dartium_test.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/darti...
pkg/stack_trace/test/dartium_test.dart:61: test('with no argument returns a
trace starting at the current frame', () {
On 2013/06/26 17:01:05, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/vm_te...
File pkg/stack_trace/test/vm_test.dart (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/stack_trace/test/vm_te...
pkg/stack_trace/test/vm_test.dart:61: test('with no argument returns a trace
starting at the current frame', () {
On 2013/06/26 17:01:05, Bob Nystrom wrote:
> long line

Done.

[Bob Nystrom, 2013-06-26 20:11:46]

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status#newcode60
pkg/pkg.status:60: stack_trace/test/dartium_test: Fail # Dartium-specific traces
On 2013/06/26 20:08:01, nweiz wrote:
> On 2013/06/26 17:01:05, Bob Nystrom wrote:
> > Would "Skip" or "Fail, OK" be better here?
> 
> I don't think we want to skip, since if this ever succeeds something
unexpected
> is going on. I'm not sure what the difference between "Fail" and "Fail, OK"
is.

I think "Fail, OK" means "this tests is intended to fail and its not a bug". But
I would ask Emily or someone who knows more than I.

[nweiz, 2013-06-26 20:18:48]

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/17765004/diff/3001/pkg/pkg.status#newcode60
pkg/pkg.status:60: stack_trace/test/dartium_test: Fail # Dartium-specific traces
On 2013/06/26 20:11:46, Bob Nystrom wrote:
> On 2013/06/26 20:08:01, nweiz wrote:
> > On 2013/06/26 17:01:05, Bob Nystrom wrote:
> > > Would "Skip" or "Fail, OK" be better here?
> > 
> > I don't think we want to skip, since if this ever succeeds something
> unexpected
> > is going on. I'm not sure what the difference between "Fail" and "Fail, OK"
> is.
> 
> I think "Fail, OK" means "this tests is intended to fail and its not a bug".
But
> I would ask Emily or someone who knows more than I.

You're right. Done.

[nweiz, 2013-06-27 00:28:35]

Committed patchset #5 manually as r24502 (presubmit successful).