Add support for V8 and Firefox stack traces in pkg/stack_trace.

pkg/stack_trace/lib/src/trace.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library trace;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'frame.dart';
 import 'lazy_trace.dart';
 
 final _terseRegExp = new RegExp(r"(-patch)?(/.*)?$");
 
+final _firefoxTrace = new RegExp(r"^[.0-9A-Za-z_$]*@");

[Bob Nystrom, 2013/06/26 17:01:05]

Document what this is for and an example of what this matches.

[nweiz, 2013/06/26 20:08:01]

Done.

+
 /// A stack trace, comprised of a list of stack frames.
 class Trace implements StackTrace {
   /// The stack frames that comprise this stack trace.
   final List<Frame> frames;
 
   /// Returns a human-readable representation of [stackTrace]. If [terse] is
   /// set, this folds together multiple stack frames from the Dart core
   /// libraries, so that only the core library method directly called from user
   /// code is visible (see [Trace.terse]).
   static String format(StackTrace stackTrace, {bool terse: true}) {
@@ skipping 25 matching lines @@
   ///
   /// If [trace] is a native [StackTrace], its data will be parsed out; if it's
   /// a [Trace], it will be returned as-is.
   factory Trace.from(StackTrace trace) {
     if (trace is Trace) return trace;
     return new LazyTrace(() => new Trace.parse(trace.toString()));
   }
 
   /// Parses a string representation of a stack trace.
   ///
-  /// [trace] should be formatted in the same way as native stack traces.
-  Trace.parse(String trace)
-      : this(trace.trim().split("\n").map((line) => new Frame.parse(line)));
+  /// [trace] should be formatted in the same way as a Dart VM or browser stack
+  /// trace.
+  factory Trace.parse(String trace) {
+    if (trace.startsWith("Error\n")) return new Trace.parseV8(trace);
+    if (trace.contains(_firefoxTrace)) return new Trace.parseFirefox(trace);
+
+    // Default to parsing the stack trace as a VM trace. This is also hit on IE
+    // and Safari, where the stack trace is just an empty string (issue 11257).
+    return new Trace.parseVM(trace);
+  }
+
+  /// Parses a string representation of a Dart VM stack trace.
+  Trace.parseVM(String trace)
+      : this(trace.trim().split("\n").map((line) => new Frame.parseVM(line)));
+
+  /// Parses a string representation of a Chrome/V8 stack trace.
+  Trace.parseV8(String trace)
+      : this(trace.split("\n").skip(1).map((line) => new Frame.parseV8(line)));
+
+  /// Parses a string representation of a Firefox stack trace.
+  Trace.parseFirefox(String trace)
+      : this(trace.trim().split("\n")
+          .map((line) => new Frame.parseFirefox(line)));
 
   /// Returns a new [Trace] comprised of [frames].
   Trace(Iterable<Frame> frames)
       : frames = new UnmodifiableListView<Frame>(frames.toList());
 
   // TODO(nweiz): Keep track of which [Frame]s are part of the partial stack
   // trace and only print them.
   /// Returns a string representation of this stack trace.
   ///
   /// This is identical to [toString]. It will not be formatted in the manner of
@@ skipping 60 matching lines @@
   if (string.length >= length) return string;
 
   var result = new StringBuffer();
   result.write(string);
   for (var i = 0; i < length - string.length; i++) {
     result.write(' ');
   }
 
   return result.toString();
 }