Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 177473004: Handle collected objects and expired handles more gracefully. (Closed)

Created:
6 years, 9 months ago by turnidge
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Handle collected objects and expired handles more gracefully. Prints <collected> or <expired>. Added tooltips to explain these to users. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33386

Patch Set 1 #

Patch Set 2 : minor edits #

Patch Set 3 : gen js / fix bug #

Patch Set 4 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6936 lines, -7091 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 650 chunks +3429 lines, -3541 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 650 chunks +3429 lines, -3541 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart View 1 2 3 2 chunks +30 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_id_ring.h View 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object_id_ring.cc View 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 3 chunks +40 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_bad_object_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
6 years, 9 months ago (2014-03-04 23:29:39 UTC) #1
Cutch
lgtm but please wait to land.
6 years, 9 months ago (2014-03-05 17:45:06 UTC) #2
turnidge
6 years, 9 months ago (2014-03-06 17:38:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r33386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698