runtime/vm/object_id_ring.cc - Issue 177473004: Handle collected objects and expired handles more gracefully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_id_ring.cc

Issue 177473004: Handle collected objects and expired handles more gracefully. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_id_ring.cc

diff --git a/runtime/vm/object_id_ring.cc b/runtime/vm/object_id_ring.cc

index 434463b734cdfec29e24da22700b27415feab42c..fd069888cd6b2ea42c99f300b9aaf946180ada88 100644

--- a/runtime/vm/object_id_ring.cc

+++ b/runtime/vm/object_id_ring.cc

@@ -33,7 +33,8 @@ int32_t ObjectIdRing::GetIdForObject(RawObject* object) {

RawObject* ObjectIdRing::GetObjectForId(int32_t id) {

int32_t index = IndexOfId(id);

if (index == kInvalidId) {

- return Object::null();

+ // Return sentinel to allow caller to distinguish expired ids.

+ return Object::sentinel().raw();

}

ASSERT(index >= 0);

ASSERT(index < capacity_);

« no previous file with comments | « runtime/vm/object_id_ring.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »