Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 17742003: Fixes floating point bug in ARM simulator. (Closed)

Created:
7 years, 6 months ago by zra
Modified:
7 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes floating point bug in ARM simulator. Adjusts status files to match. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24473

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -38 lines) Patch
M runtime/vm/intrinsifier_arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.h View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 3 10 chunks +51 lines, -27 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
When sregister_[R] contained a NaN value. get_sregister(R) would sometimes return a *different* NaN value. This ...
7 years, 6 months ago (2013-06-26 00:29:39 UTC) #1
regis
LGTM Good find!
7 years, 6 months ago (2013-06-26 00:45:32 UTC) #2
zra
7 years, 6 months ago (2013-06-26 15:48:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r24473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698