Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 17738007: Removed overloads for WebGLRenderingContext.texImage2d. (Closed)

Created:
7 years, 6 months ago by Andrei Mouravski
Modified:
7 years, 5 months ago
Reviewers:
Emily Fortuna, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed overloads for WebGLRenderingContext.texImage2D and texSubImage2D. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24670

Patch Set 1 #

Patch Set 2 : Added SubImage #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -102 lines) Patch
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 2 4 chunks +46 lines, -96 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 2 4 chunks +54 lines, -6 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tools/dom/templates/html/impl/impl_WebGLRenderingContext.darttemplate View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Andrei Mouravski
Let me know if this makes sense to you.
7 years, 6 months ago (2013-06-25 23:17:29 UTC) #1
blois
Have you synced with Emily on this?
7 years, 6 months ago (2013-06-26 16:23:20 UTC) #2
Andrei Mouravski
On 2013/06/26 16:23:20, blois wrote: > Have you synced with Emily on this? Negative. Emily, ...
7 years, 6 months ago (2013-06-26 17:07:21 UTC) #3
Andrei Mouravski
Ping.
7 years, 5 months ago (2013-06-27 22:49:02 UTC) #4
Andrei Mouravski
Ping again. I think this CL still makes sense.
7 years, 5 months ago (2013-07-01 23:16:00 UTC) #5
Emily Fortuna
On 2013/07/01 23:16:00, Andrei Mouravski wrote: > Ping again. I think this CL still makes ...
7 years, 5 months ago (2013-07-01 23:19:27 UTC) #6
Emily Fortuna
lgtm
7 years, 5 months ago (2013-07-01 23:55:10 UTC) #7
Andrei Mouravski
7 years, 5 months ago (2013-07-02 00:01:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r24670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698