Issue 177093010: Use a tag bit for indicating prologue weak persistent handles, this avoids

Issue 177093010: Use a tag bit for indicating prologue weak persistent handles, this avoids (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use a tag bit for indicating prologue weak persistent handles, this avoids the costly lookup to determine if a handle is a prologue weak persistent handle or a regular weak persistent handle in Dart_DeleteWeakPersistentHandle R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33254

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -101 lines)			Patch
M	runtime/vm/dart_api_impl.h	View	1 2 3 4	1 chunk	+0 lines, -13 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3 4	10 chunks	+57 lines, -53 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/dart_api_state.h	View	1 2 3 4	6 chunks	+44 lines, -11 lines	0 comments	Download
M	runtime/vm/gc_marker.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/handles.h	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/handles_impl.h	View	1 2 3 4	2 chunks	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3 4	2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/verifier.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/verifier.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with cleanups. -Ivan https://codereview.chromium.org/177093010/diff/50001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/177093010/diff/50001/runtime/vm/dart_api_impl.cc#newcode615 runtime/vm/dart_api_impl.cc:615: FinalizablePersistentHandle* finalizable_ref = handles->AllocateHandle(); The ...

6 years, 9 months ago (2014-03-03 21:00:19 UTC) #3

siva

https://codereview.chromium.org/177093010/diff/50001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/177093010/diff/50001/runtime/vm/dart_api_impl.cc#newcode615 runtime/vm/dart_api_impl.cc:615: FinalizablePersistentHandle* finalizable_ref = handles->AllocateHandle(); On 2014/03/03 21:00:19, Ivan Posva ...

6 years, 9 months ago (2014-03-04 00:24:48 UTC) #4

siva

6 years, 9 months ago (2014-03-04 00:35:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r33254 (presubmit successful).

Expand Messages | Collapse Messages