Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: runtime/vm/isolate.cc

Issue 177093010: Use a tag bit for indicating prologue weak persistent handles, this avoids (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/handles_impl.h ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
===================================================================
--- runtime/vm/isolate.cc (revision 33249)
+++ runtime/vm/isolate.cc (working copy)
@@ -728,10 +728,10 @@
FinalizeWeakPersistentHandlesVisitor() {
}
- void VisitHandle(uword addr) {
+ void VisitHandle(uword addr, bool is_prologue_weak) {
FinalizablePersistentHandle* handle =
reinterpret_cast<FinalizablePersistentHandle*>(addr);
- FinalizablePersistentHandle::Finalize(handle);
+ FinalizablePersistentHandle::Finalize(handle, is_prologue_weak);
}
private:
@@ -779,8 +779,9 @@
// Finalize any weak persistent handles with a non-null referent.
FinalizeWeakPersistentHandlesVisitor visitor;
- api_state()->weak_persistent_handles().VisitHandles(&visitor);
- api_state()->prologue_weak_persistent_handles().VisitHandles(&visitor);
+ api_state()->weak_persistent_handles().VisitHandles(&visitor, false);
+ api_state()->prologue_weak_persistent_handles().VisitHandles(
+ &visitor, true);
CompilerStats::Print();
if (FLAG_trace_isolates) {
« no previous file with comments | « runtime/vm/handles_impl.h ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698