Issue 17635006: Add a TypeInformation abstraction in the inferrer, that holds information per element, to get rid o…

Issue 17635006: Add a TypeInformation abstraction in the inferrer, that holds information per element, to get rid o… (Closed)

Created:
7 years, 6 months ago by ngeoffray

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a TypeInformation abstraction in the inferrer, that holds information per element, to get rid of some maps. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24386

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+330 lines, -283 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1	38 chunks	+315 lines, -268 lines	0 comments	Download
M	tests/compiler/dart2js/call_site_simple_type_inferer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/field_type_simple_inferer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/list_tracer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_and_or_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_closure_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_final_field2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_final_field3_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_final_field_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_try_catch_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM if you make sure you don't have static warnings in the code. https://codereview.chromium.org/17635006/diff/1/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File ...

7 years, 6 months ago (2013-06-25 07:41:14 UTC) #2

ngeoffray

Thanks Kasper. I added empty setters in TypeInformation to avoid the warnings. https://codereview.chromium.org/17635006/diff/1/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart ...

7 years, 6 months ago (2013-06-25 08:19:35 UTC) #3

ngeoffray

7 years, 6 months ago (2013-06-25 08:34:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24386 (presubmit successful).

Expand Messages | Collapse Messages