Add a TypeInformation abstraction in the inferrer, that holds information per element, to get rid o…

tests/compiler/dart2js/simple_inferrer_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:expect/expect.dart';
 import
     '../../../sdk/lib/_internal/compiler/implementation/types/types.dart'
     show TypeMask;
 
 import 'compiler_helper.dart';
@@ skipping 473 matching lines @@
 void main() {
   Uri uri = new Uri(scheme: 'source');
   var compiler = compilerFor(TEST, uri);
   compiler.runCompiler(uri);
   var typesInferrer = compiler.typesTask.typesInferrer;
 
   checkReturn(String name, type) {
     var element = findElement(compiler, name);
     Expect.equals(
         type,
-        typesInferrer.internal.returnTypeOf[element].simplify(compiler),
+        typesInferrer.getReturnTypeOfElement(element).simplify(compiler),
         name);
   }
   var interceptorType =
       findTypeMask(compiler, 'Interceptor', 'nonNullSubclass');
 
   checkReturn('returnNum1', typesInferrer.numType);
   checkReturn('returnNum2', typesInferrer.numType);
   checkReturn('returnInt1', typesInferrer.intType);
   checkReturn('returnInt2', typesInferrer.intType);
   checkReturn('returnDouble', typesInferrer.doubleType);
@@ skipping 47 matching lines @@
   checkReturn('testBreak2', typesInferrer.intType.nullable());
   checkReturn('testReturnElementOfConstList1', typesInferrer.intType);
   checkReturn('testReturnElementOfConstList2', typesInferrer.intType);
   checkReturn('testReturnItselfOrInt', typesInferrer.intType);
   checkReturn('testReturnInvokeDynamicGetter', typesInferrer.dynamicType);
 
   checkReturnInClass(String className, String methodName, type) {
     var cls = findElement(compiler, className);
     var element = cls.lookupLocalMember(buildSourceString(methodName));
     Expect.equals(type,
-        typesInferrer.internal.returnTypeOf[element].simplify(compiler));
+        typesInferrer.getReturnTypeOfElement(element).simplify(compiler));
   }
 
   checkReturnInClass('A', 'returnInt1', typesInferrer.intType);
   checkReturnInClass('A', 'returnInt2', typesInferrer.intType);
   checkReturnInClass('A', 'returnInt3', typesInferrer.intType);
   checkReturnInClass('A', 'returnInt4', typesInferrer.intType);
   checkReturnInClass('A', 'returnInt5', typesInferrer.intType);
   checkReturnInClass('A', 'returnInt6', typesInferrer.intType);
   checkReturnInClass('A', '==', interceptorType);
 
   checkReturnInClass('B', 'returnInt1', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt2', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt3', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt4', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt5', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt6', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt7', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt8', typesInferrer.intType);
   checkReturnInClass('B', 'returnInt9', typesInferrer.intType);
 
   checkFactoryConstructor(String className) {
     var cls = findElement(compiler, className);
     var element = cls.localLookup(buildSourceString(className));
     Expect.equals(new TypeMask.nonNullExact(cls.rawType),
-                  typesInferrer.internal.returnTypeOf[element]);
+                  typesInferrer.getReturnTypeOfElement(element));
   }
   checkFactoryConstructor('A');
 }