Issue 175223004: Revert "Add lock to a file handle in windows event handler."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 175223004: Revert "Add lock to a file handle in windows event handler." (Closed)

Created:
6 years, 10 months ago by Bill Hesse

Modified:
6 years, 10 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Add lock to a file handle in windows event handler." This reverts commit r32901. The lock causes a deadlock, and timeouts in tests. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=32906

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/bin/eventhandler_win.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

6 years, 10 months ago (2014-02-21 17:00:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32906 (presubmit successful).