runtime/bin/eventhandler_win.cc - Issue 175223004: Revert "Add lock to a file handle in windows event handler."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_win.cc

Issue 175223004: Revert "Add lock to a file handle in windows event handler." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_win.cc

diff --git a/runtime/bin/eventhandler_win.cc b/runtime/bin/eventhandler_win.cc

index ce9b47e156e959c51da559f13db381fa5d5b46ab..1fdbe204b72af65900b1ac2ed7fa0b0ef1f2540f 100644

--- a/runtime/bin/eventhandler_win.cc

+++ b/runtime/bin/eventhandler_win.cc

@@ -233,7 +233,6 @@ static void ReadFileThread(uword args) {

void Handle::ReadSyncCompleteAsync() {

- ScopedLock lock(this);

ASSERT(pending_read_ != NULL);

ASSERT(pending_read_->GetBufferSize() >= kStdOverlappedBufferSize);

« no previous file with comments | « no previous file | no next file » | no next file with comments »