Analysis server connect fixes

Analysis server connect fixes
+ new option for connecting to already running analysis server
+ gracefully handle unknown arguments
+ fix bugs in analysis server websocket connect

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32974

[Brian Wilkerson, 2014-02-22 16:57:05]

LGTM

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/analysis_manager.dart (right):

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:19: * or [:null:] if managing
an analysis server that was already running.
nit: We have been using backquotes (`) in the rest of the server code base.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:35:
PORT.toString()]).then(_attach);
We should have a 'catchError' to report when the server could not be started.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:50: static
Future<AnalysisManager> _attach(Process process) {
I think we also want to use the 'exitCode' getter in order to be notified when
the process exits.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:80: * Returns [:true:] if the
signal is successfully sent and process is killed.
nit: As above

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:84: bool stop() => process !=
null ? process.kill() : false;
I still think you should ask the server nicely to stop running.

[danrubel, 2014-02-24 17:39:24]

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/analysis_manager.dart (right):

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:19: * or [:null:] if managing
an analysis server that was already running.
On 2014/02/22 16:57:06, Brian Wilkerson wrote:
> nit: We have been using backquotes (`) in the rest of the server code base.

Done.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:35:
PORT.toString()]).then(_attach);
On 2014/02/22 16:57:06, Brian Wilkerson wrote:
> We should have a 'catchError' to report when the server could not be started.

Done.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:50: static
Future<AnalysisManager> _attach(Process process) {
On 2014/02/22 16:57:06, Brian Wilkerson wrote:
> I think we also want to use the 'exitCode' getter in order to be notified when
> the process exits.

Done.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:80: * Returns [:true:] if the
signal is successfully sent and process is killed.
On 2014/02/22 16:57:06, Brian Wilkerson wrote:
> nit: As above

Done.

https://codereview.chromium.org/175183008/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_manager.dart:84: bool stop() => process !=
null ? process.kill() : false;
On 2014/02/22 16:57:06, Brian Wilkerson wrote:
> I still think you should ask the server nicely to stop running.

Agreed. Not quite ready to wire that up. Added a comment that this needs to be
done.

[danrubel, 2014-02-24 17:41:27]

Committed patchset #4 manually as r32974 (presubmit successful).