Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 175183008: Analysis server connect fixes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 90fca909b11d5cacd3aeaf0c624dce3a4fcb97fa..3cd1305ab31b90f4c850f1e49815255598bceca5 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -35,7 +35,7 @@ class AnalysisServer {
* The channel from which requests are received and to which responses should
* be sent.
*/
- CommunicationChannel channel;
+ final CommunicationChannel channel;
/**
* A flag indicating whether the server is running.
@@ -63,11 +63,11 @@ class AnalysisServer {
* Initialize a newly created server to receive requests from and send
* responses to the given [channel].
*/
- AnalysisServer(CommunicationChannel channel) {
+ AnalysisServer(this.channel) {
AnalysisEngine.instance.logger = new AnalysisLogger();
running = true;
- this.channel = channel;
- this.channel.listen(handleRequest, onError: error, onDone: done);
+ // TODO set running=false on done or error
+ channel.listen(handleRequest);
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698