Add safari cache clearing browser functionality to the safari browser.

Add safari cache clearing browser functionality to the safari browser.

Also, add flag to test.dart to enable this feature.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24215

[kustermann, 2013-06-20 09:21:04]

https://codereview.chromium.org/17489002/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/17489002/diff/1/tools/test.dart#newcode174
tools/test.dart:174: maxBrowserProcesses = math.max(maxProcesses - 3, 1);
Please set this to 1 since multiple browsers are never supported on Mac.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:206: var args = ["-rf",
"\$HOME/Library/Caches/com.apple.Safari"];
As discussed offline, this doesn't work.
Please read the environment using 'dart:io' and delete using
Directory.delete(recursive: true) [or something like that].

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:277: }).catchError((e) {
e -> error.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:287: static bool deleteCache = false;
Add a comment here.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:319: 'Cleanuot the safari cache (i.e.,
delete it).',
Cleanuot -> Clear

[ricow1, 2013-06-20 10:24:05]

https://codereview.chromium.org/17489002/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/17489002/diff/1/tools/test.dart#newcode174
tools/test.dart:174: maxBrowserProcesses = math.max(maxProcesses - 3, 1);
On 2013/06/20 09:21:04, kustermann wrote:
> Please set this to 1 since multiple browsers are never supported on Mac.

Done.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:206: var args = ["-rf",
"\$HOME/Library/Caches/com.apple.Safari"];
On 2013/06/20 09:21:04, kustermann wrote:
> As discussed offline, this doesn't work.
> Please read the environment using 'dart:io' and delete using
> Directory.delete(recursive: true) [or something like that].

Done.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:277: }).catchError((e) {
On 2013/06/20 09:21:04, kustermann wrote:
> e -> error.

Done.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:287: static bool deleteCache = false;
On 2013/06/20 09:21:04, kustermann wrote:
> Add a comment here.

Done.

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/17489002/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:319: 'Cleanuot the safari cache (i.e.,
delete it).',
On 2013/06/20 09:21:04, kustermann wrote:
> Cleanuot -> Clear

Done.

[kustermann, 2013-06-20 10:27:22]

lgtm

[ricow1, 2013-06-20 10:30:09]

Committed patchset #2 manually as r24215 (presubmit successful).