Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tools/test.dart

Issue 17489002: Add safari cache clearing browser functionality to the safari browser. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/browser_controller.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
===================================================================
--- tools/test.dart (revision 24136)
+++ tools/test.dart (working copy)
@@ -27,6 +27,7 @@
import "dart:async";
import "dart:io";
import "dart:math" as math;
+import "testing/dart/browser_controller.dart";
import "testing/dart/http_server.dart";
import "testing/dart/record_and_replay.dart";
import "testing/dart/test_options.dart";
@@ -92,6 +93,10 @@
var recordingPath = firstConf['record_to_file'];
var recordingOutputPath = firstConf['replay_from_file'];
+ // We set a special flag in the safari browser if we need to clear out
+ // the cache before running.
+ Safari.deleteCache = firstConf['clear_safari_cache'];
+
if (recordingPath != null && recordingOutputPath != null) {
print("Fatal: Can't have the '--record_to_file' and '--replay_from_file'"
"at the same time. Exiting ...");
@@ -164,9 +169,9 @@
maxBrowserProcesses = 1;
} else if (conf['runtime'].startsWith('safari') &&
conf['use_browser_controller']) {
- // FIXME(kustermann/ricow): Remove this once the new browser_controller is
- // stable.
- maxBrowserProcesses = math.max(maxProcesses - 3, 1);
+ // Safari does not allow us to run from a fresh profile, so we can only
+ // use one browser.
+ maxBrowserProcesses = 1;
}
for (String key in selectors.keys) {
@@ -244,7 +249,6 @@
}
eventListener.add(new ExitCodeSetter());
-
void startProcessQueue() {
// Start process queue.
new ProcessQueue(maxProcesses,
« no previous file with comments | « no previous file | tools/testing/dart/browser_controller.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698