interceptedNames should include all interceptor method generated, not just the ones called.

interceptedNames should include all interceptor method generated, not just the ones called.

BUG=http://dartbug.com/11309
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24140

[ngeoffray, 2013-06-18 12:45:02]

Do we agree that it's a bug if something is generated but not called, and
mirrors are disabled? If yes, LGTM :)

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2985: //
TODO(ahe): We should not include this list, it can be generated
I don't understand this comment:
'include' = 'generate ? 
'this list' = the list of interceptor invocation  names ?
'generated' = 'generated at runtime' ?

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1553: void
registerInvoke(HInvokeDynamic node, Selector selector) {}
I'd get rid of this method.

[ahe, 2013-06-18 12:54:56]

On 2013/06/18 12:45:02, ngeoffray wrote:
> Do we agree that it's a bug if something is generated but not called, and
> mirrors are disabled? If yes, LGTM :)

Yes.

[ahe, 2013-06-18 12:55:07]

Thank you, Nicolas!

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2985: //
TODO(ahe): We should not include this list, it can be generated
On 2013/06/18 12:45:02, ngeoffray wrote:
> I don't understand this comment:
> 'include' = 'generate ? 
> 'this list' = the list of interceptor invocation  names ?
> 'generated' = 'generated at runtime' ?

Done.

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/17389003/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1553: void
registerInvoke(HInvokeDynamic node, Selector selector) {}
On 2013/06/18 12:45:02, ngeoffray wrote:
> I'd get rid of this method.

Done.

[ahe, 2013-06-18 12:56:22]

FYI: patch set which address Nicolas' comments has been uploaded.

[ahe, 2013-06-18 13:19:00]

Committed patchset #2 manually as r24140 (presubmit successful).